Fix memory leak of direct memory in direct memory entry logger.#3983
Merged
hezhangjian merged 1 commit intoJun 13, 2023
Merged
Conversation
dlg99
approved these changes
Jun 12, 2023
zymap
approved these changes
Jun 13, 2023
hezhangjian
approved these changes
Jun 13, 2023
zymap
pushed a commit
that referenced
this pull request
Jun 19, 2023
Descriptions of the changes in this PR: ### Motivation When open a non-exist file for DirectReader, it will throw an exception. The ByteBuf won't release. When close DirectWriter, if the close failed, the ByteBuf also won't release. (cherry picked from commit c8c593e)
Merged
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Descriptions of the changes in this PR: ### Motivation When open a non-exist file for DirectReader, it will throw an exception. The ByteBuf won't release. When close DirectWriter, if the close failed, the ByteBuf also won't release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
When open a non-exist file for DirectReader, it will throw an exception. The ByteBuf won't release.
When close DirectWriter, if the close failed, the ByteBuf also won't release.