-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Client] Group writing into the channel in PerChannelBookieClient #3886
Open
hangc0276
wants to merge
8
commits into
apache:master
Choose a base branch
from
hangc0276:chenhang/group_writing_for_perBookieClient
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4cc7dbb
group write for perBookieClient
hangc0276 c1da2a3
format code
hangc0276 b496c15
group write for perBookieClient
hangc0276 d5ad526
format code
hangc0276 2417b4e
fix a bug
hangc0276 98b844d
tmp
hangc0276 ab95ba6
use new impl
hangc0276 4ae8e53
address comments
hangc0276 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
address comments
- Loading branch information
commit 4ae8e532027ed999536c37f4496c61448a59c086
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flushPendingRequests trigger at every millisecond. It may exacerbate the lock race between
prepareSendRequests
andflushPendingRequests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we can refer to the implements of
writeCache and writeCacheBeingFlushed in the SingleDirectoryDbLedgerStorage
to make flushPendingRequests lock-free.