Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary force write. #3847

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Avoid unnecessary force write. #3847

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
762f66b
Avoid unnecessary force write.
horizonzy Mar 7, 2023
bb8e59a
code clean.
horizonzy Mar 7, 2023
877c8b6
fix style
horizonzy Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ public static class ForceWriteRequest {
private boolean shouldClose;
private long lastFlushedPosition;
private long logId;
private boolean flushed;

public int process() {
closeFileIfNecessary();
Expand All @@ -380,13 +381,20 @@ public int process() {
return forceWriteWaiters.size();
}

private void flushFileToDisk() throws IOException {
if (!flushed) {
logFile.forceWrite(false);
flushed = true;
}
}

public void closeFileIfNecessary() {
// Close if shouldClose is set
if (shouldClose) {
// We should guard against exceptions so its
// safe to call in catch blocks
try {
logFile.forceWrite(false);
flushFileToDisk();
logFile.close();
// Call close only once
shouldClose = false;
Expand Down Expand Up @@ -525,7 +533,7 @@ public void run() {
private void syncJournal(ForceWriteRequest lastRequest) throws IOException {
long fsyncStartTime = MathUtils.nowInNano();
try {
lastRequest.logFile.forceWrite(false);
lastRequest.flushFileToDisk();
journalStats.getJournalSyncStats().registerSuccessfulEvent(MathUtils.elapsedNanos(fsyncStartTime),
TimeUnit.NANOSECONDS);
lastLogMark.setCurLogMark(lastRequest.logId, lastRequest.lastFlushedPosition);
Expand Down