Avoid using thread-local WriteSet when possible

[merlimat]

Motivation

For computing WriteSet we use a Recycler to avoid instantiating a new object each time. While that avoid allocations, it's based on thread-locals and has non-zero cost.

In most cases the usage of WriteSet that we are doing is very basic:

• Get a WriteSet from the recycler
• check the bookie indices
• recycle the write-set

Instead, we can just expose a method in the DistributionSchedule interface and avoid any recycler or object allocations.

[codecov-commenter]

Codecov Report

Merging #3829 (dde5a59) into master (a96317e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #3829      +/-   ##
============================================
- Coverage     68.35%   68.34%   -0.02%     
- Complexity     6757     6768      +11     
============================================
  Files           473      473              
  Lines         40963    40950      -13     
  Branches       5241     5240       -1     
============================================
- Hits          28002    27987      -15     
- Misses        10706    10712       +6     
+ Partials       2255     2251       -4     

Flag	Coverage Δ
bookie	39.87% <47.36%> (-0.07%)	⬇️
client	44.18% <100.00%> (-0.03%)	⬇️
remaining	29.52% <57.89%> (-0.11%)	⬇️
replication	41.42% <84.21%> (-0.01%)	⬇️
tls	21.01% <42.10%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...apache/bookkeeper/client/DistributionSchedule.java	9.09% <ø> (ø)
...rg/apache/bookkeeper/conf/ServerConfiguration.java	77.49% <ø> (-0.17%)	⬇️
...ain/java/org/apache/bookkeeper/bookie/Journal.java	81.43% <100.00%> (-1.10%)	⬇️
...va/org/apache/bookkeeper/client/LedgerChecker.java	81.55% <100.00%> (-0.09%)	⬇️
...ava/org/apache/bookkeeper/client/PendingAddOp.java	87.62% <100.00%> (-1.22%)	⬇️
...rg/apache/bookkeeper/client/PendingWriteLacOp.java	73.17% <100.00%> (-1.25%)	⬇️
...kkeeper/client/RoundRobinDistributionSchedule.java	84.73% <100.00%> (-1.36%)	⬇️
...keeper/meta/AbstractHierarchicalLedgerManager.java	72.97% <0.00%> (-4.06%)	⬇️
...apache/bookkeeper/bookie/LedgerDescriptorImpl.java	68.42% <0.00%> (-3.51%)	⬇️
...er/util/collections/ConcurrentLongLongHashMap.java	78.71% <0.00%> (-1.99%)	⬇️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more