Backward compatibility tests: add retries #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jan 7, 2022
dlg99
approved these changes
Jan 7, 2022
pkumar-singh
approved these changes
Jan 7, 2022
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Backward compatibility tests are flaky. When they fail, they always fail due to
I spent a lot of time trying to tune connection parameters, split tests and so on, my understanding is that at certain points the machine starts suffering (he restart many times the bookies of different versions - 3 bookies and 1 zk in the same machine) and the bookie is unable to send ZK ping and then it's cut off from the ensemble.
Changes
I added the retry options to the tests with max 5 retries per test, it should be enough. (I don't have numbers to demonstrate that, we'll see it )