Fix the compatibility workflows #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepbn
force-pushed
the
fixCompatibilityWorkflow
branch
from
e38af20 to
883f770
Compare
|
rerun failure checks |
pkumar-singh
approved these changes
Nov 19, 2021
pradeepbn
force-pushed
the
fixCompatibilityWorkflow
branch
from
125aaed to
c4b67d6
Compare
pkumar-singh
approved these changes
Nov 19, 2021
|
@eolivelli could PTAL? If all is good would be good to merge. |
nicoloboschi
requested changes
Nov 22, 2021
| @@ -59,7 +59,7 @@ public void testProtobufIsShaded() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testProtobufShadedPath() throws Exception { | |||
| Class.forName("dlshade.com.google.protobuf.Message"); | |||
| Class.forName("org.apache.bookkeeper.shaded.com.google.protobuf.Message"); | |||
There was a problem hiding this comment.
Why this? I think there is a duplicate rule for com.google in the build.gradle
There was a problem hiding this comment.
Good catch- thanks. Its fixed now.
eolivelli
approved these changes
Nov 23, 2021
|
Tests didn't pass. |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Fix workflow yaml for compatibility tests * remove duplicate of com.google relocate in build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Compatibility checks workflow wasn't working because there the github workflow.yaml had syntax issues. Also, since it was enabled 1st time, there were build issues with the tests.