Update bc tests to include versions up to 4.14.0 #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
reviewed
May 25, 2021
|
|
||
| @Test | ||
| public void test480to481() throws Exception { | ||
| testUpgrade("4.8.0", "4.8.1") |
There was a problem hiding this comment.
can we drop this old stuff?
There was a problem hiding this comment.
@eolivelli I added issue #2721 to track this request. I think it makes sense to do that i separate PR/have a larger group of committers to chirp in on how far back eh backwards compat should go
eolivelli
approved these changes
May 25, 2021
Sunny-Island
pushed a commit
to Sunny-Island/bookkeeper
that referenced
this pull request
Jun 2, 2021
### Motivation 4.14.0 release ### Changes followed https://bookkeeper.apache.org/community/release_guide/#verify-docker-image and used apache#2171 as example Reviewers: Enrico Olivelli <eolivelli@gmail.com> This closes apache#2719 from dlg99/bctests-4_14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
4.14.0 release
Changes
followed https://bookkeeper.apache.org/community/release_guide/#verify-docker-image and used #2171 as example