Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table service] add default port to service hosts #1778

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

sijie
Copy link
Member

@sijie sijie commented Nov 1, 2018

Descriptions of the changes in this PR:

Motivation

Currently we have to add 4181 in the service uri in order to make it work.
Ideally it would be great that the system can fill the default port if port is missing.

Changes

add default port when parsing ServiceURI


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java9]: skip build on java9. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

*Motivation*

Currently we have to add `4181` in the service uri in order to make it work.
Ideally it would be great that the system can fill the default port if port is missing.

*Changes*

add default port when parsing `ServiceURI`
@sijie sijie added this to the 4.9.0 milestone Nov 1, 2018
@sijie sijie self-assigned this Nov 1, 2018
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
Do you need a similar fix on python client?

@sijie
Copy link
Member Author

sijie commented Nov 1, 2018

Do you need a similar fix on python client?

yes I will do it in a subsequent change.

sijie added a commit to sijie/bookkeeper that referenced this pull request Nov 1, 2018
*Motivation*

Similar as apache#1778, add default port to service hosts if port is missing.

*Changes*

add default port to service hosts if they miss ports

Related Issue: apache#1778
@sijie
Copy link
Member Author

sijie commented Nov 1, 2018

run integration tests

@sijie sijie merged commit d13bffc into apache:master Nov 2, 2018
@sijie sijie deleted the add_default_port branch November 2, 2018 21:41
sijie added a commit that referenced this pull request Nov 3, 2018
Descriptions of the changes in this PR:

*Motivation*

Similar as #1778, add default port to service hosts if port is missing.

*Changes*

add default port to service hosts if they miss ports

Related Issue: #1778




Reviewers: Jia Zhai <None>

This closes #1780 from sijie/fix_python_service_uri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants