You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should be done as part of new api work. Ideally there should be no constructor for the BookKeeper object, but everything should go through a Builder that returns a o.a.b.client.api.BookKeeper object.
Currently it's not really useful to have o.a.b.client.api.BookKeeper as you have to import o.a.b.client.BookKeeper to create one.
ClientConfiguration should probably be deprecated too, and all the configuration in it put in the builder.
ZKPatch: d8b825d6533e9848565beff09e9a018136ca32bd (extract)
Changes made to the testStartupFailure test to remember the old directory and switch back to it after the test has completed.
Author: Jeelani Mohamed Abdul Khader <mjeelani@devvm3360.prn2.facebook.com>
Reviewers: Michael Han <hanm@apache.org>, Norbert Kalmar
Closesapache#577 from mjeelanimsft/make-buffersizetest-reliable
JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-1011
Reporter: Robert Joseph Evans @revans2
One of the feedbacks from
#105 (comment)
was that there are some customer APIs that need to be cleaned up. This is specifically for the two constructors in Bookkeeper
{code}
public BookKeeper(ClientConfiguration conf, ZooKeeper zk);
public BookKeeper(ClientConfiguration conf, ZooKeeper zk, ClientSocketChannelFactory channelFactory);
{code}
That are really for internal use only. We should find a way to mark them as such.
The text was updated successfully, but these errors were encountered: