Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up internal Bookkeeper constructors #577

Open
ivankelly opened this issue Oct 17, 2017 · 2 comments
Open

Clean up internal Bookkeeper constructors #577

ivankelly opened this issue Oct 17, 2017 · 2 comments

Comments

@ivankelly
Copy link
Contributor

JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-1011

Reporter: Robert Joseph Evans @revans2

One of the feedbacks from

#105 (comment)

was that there are some customer APIs that need to be cleaned up. This is specifically for the two constructors in Bookkeeper

{code}
public BookKeeper(ClientConfiguration conf, ZooKeeper zk);
public BookKeeper(ClientConfiguration conf, ZooKeeper zk, ClientSocketChannelFactory channelFactory);
{code}

That are really for internal use only. We should find a way to mark them as such.

@ivankelly
Copy link
Contributor Author

This should be done as part of new api work. Ideally there should be no constructor for the BookKeeper object, but everything should go through a Builder that returns a o.a.b.client.api.BookKeeper object.

Currently it's not really useful to have o.a.b.client.api.BookKeeper as you have to import o.a.b.client.BookKeeper to create one.

ClientConfiguration should probably be deprecated too, and all the configuration in it put in the builder.

(cc @sijie @eolivelli )

@eolivelli
Copy link
Contributor

We could deprecate current constructors in 4.8.
Once we are OK with new API

athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
ZKPatch: d8b825d6533e9848565beff09e9a018136ca32bd (extract)

Changes made to the testStartupFailure test to remember the old directory and switch back to it after the test has completed.

Author: Jeelani Mohamed Abdul Khader <mjeelani@devvm3360.prn2.facebook.com>

Reviewers: Michael Han <hanm@apache.org>, Norbert Kalmar

Closes apache#577 from mjeelanimsft/make-buffersizetest-reliable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants