Skip to content

Commit

Permalink
BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper
Browse files Browse the repository at this point in the history
Descriptions of the changes in this PR:

Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side.

Master Issue: #1007

Author: Arvin <arvindevel@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>, Venkateswararao Jujjuri <vjujjuri@salesforce.com>

This closes #1008 from ArvinDevel/BP_25_MovingChecksumToProto
  • Loading branch information
ArvinDevel authored and sijie committed Jan 24, 2018
1 parent 305efca commit a512b73
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
27 changes: 27 additions & 0 deletions site/bps/BP-25-MovingChecksumToProto.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
title: "BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper"
issue: https://github.com/apache/bookkeeper/issues/1007
state: "Accepted"
release: "N/A"
---

### Motivation

Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side.

### Public Interfaces

An internal refactor not affecting public interfaces.

### Proposed Changes

Move the DigestManager and related classes to proto module

### Compatibility, Deprecation, and Migration Plan
N/A

### Test Plan
The original all tests should work as before.

### Rejected Alternatives
N/A
2 changes: 1 addition & 1 deletion site/community/bookkeeper_proposals.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ using Google Doc.

This section lists all the _bookkeeper proposals_ made to BookKeeper.

*Next Proposal Number: 23*
*Next Proposal Number: 26*

### Inprogress

Expand Down

0 comments on commit a512b73

Please sign in to comment.