-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-7011] Update Beam SDKs to use the StandardSideInputType enums. #8232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @lostluck |
|
@lukecwik You'll need to clean up the go imports for this change to compile, as Go has strict include what you use semantics. 18:02:25 .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/runners/dataflow/dataflowlib/fixup.go:19:2: imported and not used: "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/graphx" |
|
Thanks Robert Is there tooling that does this automatically? |
|
There are, but most IDEs configured for Go should be automatically downloading and using them onsave. |
|
R: @lostluck |
|
LGTM |
|
Note: I think the formatting changes in the go code are from go version differences for whomever is running |
|
Yes, I use go 1.12 locally, didn't know that the fmt had changed. |
|
Run Python PreCommit |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Python PreCommit |
|
Run Java PreCommit |
|
Run Python PreCommit |
|
Run Java PreCommit |
… enums. (apache#8232)" This reverts commit 684f813.
…pache#8232) * [BEAM-7011] Update Beam to use the StandardSideInputType enums.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.