[BEAM-5323] Finish Python 3 porting for utils module #6359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
commented
Sep 10, 2018
| @@ -209,7 +209,6 @@ def wrapper(*args, **kwargs): | |||
| # Traceback objects in locals can cause reference cycles that will | |||
| # prevent garbage collection. Clear it now since we do not need | |||
| # it anymore. | |||
| sys.exc_clear() | |||
There was a problem hiding this comment.
sys.exc_clear has been removed in Python 3.
Reading the docs, this call does not seem necessary as long as the local variable with reference to the traceback is removed.
aaltay
approved these changes
Sep 10, 2018
|
Can we remove the corresponding comment here too? CC: @robertwb who may know more about the reference counting issues from before. |
|
@charlesccychen I think the comment is still relevant since the line 213 clears the reference to traceback stored in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here.
Post-Commit Tests Status (on master branch)