[BEAM-22] Close Readers in InProcess Read Evaluators#52
Closed
tgroh wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-22] Close Readers in InProcess Read Evaluators#52tgroh wants to merge 2 commits intoapache:masterfrom
tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
The readers were formerly left open, which prevents release of any resources that should be released.
Member
|
R: me! |
| @@ -104,36 +103,39 @@ private <OutputT> Queue<BoundedReadEvaluator<OutputT>> getTransformEvaluatorQueu | |||
| private static class BoundedReadEvaluator<OutputT> implements TransformEvaluator<Object> { | |||
Member
There was a problem hiding this comment.
It might be worth a smidgin of implementation detail javadoc here mentioning that the reader is only actually opened on finish bundle. It is a private class anyhow, but may direct your future self to the right place to look if there is a bug.
Add comments to the evaluators to note proper caller hygiene
davorbonaci
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Mar 25, 2016
axelmagn
pushed a commit
to axelmagn/beam
that referenced
this pull request
Apr 9, 2018
Fix pipeline options reading in Java SDK harness
hengfengli
referenced
this pull request
in hengfengli/beam
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readers were formerly left open, which prevents release of any
resources that should be released or additional on-close behavior.