Skip to content

Conversation

@dhalperi
Copy link
Contributor

  • Add package-info.java to two missing packages.
  • Fix a compile error leftover from changing a link to a code block,
    which requires dropping HTML escaping of brackets.

R @davorbonaci

- Add package-info.java to two missing packages.
- Fix a compile error leftover from changing a link to a code block,
  which requires dropping HTML escaping of brackets.
@davorbonaci
Copy link
Member

Travis error seems unrelated. @mxm, any thoughts? I'll retry the test.

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.beam.runners.flink.streaming.GroupByNullKeyTest
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGBUS (0x7) at pc=0x00007f0dffbe97d2, pid=5132, tid=139698220291840
#
# JRE version: Java(TM) SE Runtime Environment (8.0_31-b13) (build 1.8.0_31-b13)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.31-b07 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libzip.so+0x117d2]  newEntry+0x62
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/travis/build/apache/incubator-beam/hs_err_pid5132.log
Compiled method (nm)  271177  115     n 0       java.util.zip.ZipFile::getEntry (native)
 total in heap  [0x00007f0df0f53050,0x00007f0df0f533c0] = 880
 relocation     [0x00007f0df0f53178,0x00007f0df0f531c0] = 72
 main code      [0x00007f0df0f531c0,0x00007f0df0f533c0] = 512
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
/home/travis/build.sh: line 172:  5132 Aborted                 (core dumped) "$@"
The command "mvn -B -DforkCount=0 install -U" failed 3 times.

LGTM otherwise.

@mxm
Copy link
Contributor

mxm commented Mar 15, 2016

@davorbonaci Never seen this one before. The error occurs in java.util.zip.ZipFile::getEntry, so probably while accessing a corrupted class file inside a Jar. Or maybe disk space full. Looks like a Travis related problem.

PR looks good!

@asfgit asfgit merged commit 9603141 into apache:master Mar 17, 2016
asfgit pushed a commit that referenced this pull request Mar 17, 2016
@dhalperi dhalperi deleted the javadoc-fixes branch March 24, 2016 21:49
davorbonaci added a commit to GoogleCloudPlatform/DataflowJavaSDK that referenced this pull request Mar 25, 2016
axelmagn pushed a commit to axelmagn/beam that referenced this pull request Apr 3, 2018
Nit: Validate not closed when accessing state delegator.
tvalentyn pushed a commit to tvalentyn/beam that referenced this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants