Repository navigation
[Solace] Add OpenTelemetry distributed tracing support to SolaceIO (#40175) - #40482
Open
stankiewicz wants to merge 1 commit into
Open
stankiewicz wants to merge 1 commit into
stankiewicz wants to merge 1 commit into
Conversation
stankiewicz
marked this pull request as draft
October 9, 2026 09:46
stankiewicz
marked this pull request as ready for review
October 9, 2026 09:48
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40482 +/- ##
============================================
+ Coverage 56.16% 65.26% +9.09%
- Complexity 2288 13917 +11629
============================================
Files 1124 1720 +596
Lines 178336 107826 -70510
Branches 1489 11243 +9754
============================================
- Hits 100170 70369 -29801
+ Misses 75645 33270 -42375
- Partials 2521 4187 +1666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40175
Supersedes #40187
Summary
Adds OpenTelemetry distributed tracing support to both
SolaceIO.ReadandSolaceIO.Write, aligned withKafkaIOandPubsubIOand utilizingSolace.Recorduser properties introduced in #40108 for W3C Trace Context propagation (traceparent,tracestate).Changes
sdks/java/io/solace/build.gradle):opentelemetry_bom,opentelemetry_api, andopentelemetry_contexttoimplementation.opentelemetry_sdkandopentelemetry_sdk_testingtotestImplementation.SolaceIO.Read&OpenTelemetryHeaderConsumer):withEnableOpenTelemetryTracing()onSolaceIO.Read(defaultfalse).ParDo.of(new OpenTelemetryHeaderConsumer<>())inSolaceIO.Read.expand().Tracer("SolaceIO") fromoptions.as(SdkHarnessOptions.class).getOpenTelemetry().traceparent,tracestate, with case-insensitive header lookup) fromSolace.Record.getUserProperties()viaW3CTraceContextPropagator.getInstance().extract(...)andTextMapGetter<Record>."SolaceIO.Read"span withSpanKind.CONSUMERandsetParent(context)wrappingreceiver.output(element)so Beam propagates the OpenTelemetry context inWindowedValue.SolaceIO.Write&OpenTelemetryHeaderPropagator):withEnableOpenTelemetryTracing()onSolaceIO.Write(defaultfalse).toBuilder()toSolace.Record.ParDo.of(new OpenTelemetryHeaderPropagator())inSolaceIO.Write.expand()."SolaceIO.Write"span withSpanKind.PRODUCERandsetParent(Context.current()), injecting the active W3C trace context into a copy ofSolace.Record'suserPropertiesviaW3CTraceContextPropagator.getInstance().inject(...)andTextMapSetter<Record>.SolaceIOReadTest: Verified configuration toggle andSpanKind.CONSUMERspan creation, parent trace/span ID linkage, case-insensitiveTraceParentextraction, andtracestatepreservation usingInMemorySpanExporter.SolaceIOWriteTest: Verified configuration toggle,SpanKind.PRODUCERspan creation for bothSTREAMINGandBATCHEDwriters, W3Ctraceparentinjection intoSolace.Recorduser properties and JCSMPSDTMapmessage properties, and end-to-end consumer-to-producer trace context continuity.