Repository navigation
[SpannerIO] Add withWriteResults() to SpannerIO.Write to emit commit metadata - #40480
Open
stankiewicz wants to merge 1 commit into
Open
stankiewicz wants to merge 1 commit into
stankiewicz wants to merge 1 commit into
Conversation
Contributor
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
withWriteResults()toSpannerIO.WriteandSpannerIO.WriteGrouped(modeled afterBigtableIO.Write#withWriteResults()) to optionally enableOptions.commitStats()on Cloud Spanner mutation writes and return aPCollection<WriteResults>containing commit metadata fromcom.google.cloud.spanner.CommitResponse.Changes
WriteResults:WriteResultsannotated with@DefaultCoder(AvroCoder.class)(usingTimestampEncodingforTimestampfields) exposing:getMutationCount()(long): populated fromCommitResponse.getCommitStats().getMutationCount().getCommitTimestamp()(@Nullable Timestamp): populated fromCommitResponse.getCommitTimestamp().getSnapshotTimestamp()(@Nullable Timestamp): populated fromCommitResponse.getSnapshotTimestamp().SpannerIO.Write#withWriteResults()&SpannerIO.WriteGrouped#withWriteResults():WriteWithResults(PTransform<PCollection<Mutation>, PCollection<WriteResults>>) andWriteGroupedWithResults(PTransform<PCollection<MutationGroup>, PCollection<WriteResults>>).Options.commitStats()inWriteToSpannerFn#getTransactionOptions()only whenwithWriteResults()is used, preserving full backwards compatibility and zero overhead for existingSpannerIO.write()users.@Nullable PCollection<WriteResults> getWriteResults()onSpannerWriteResult.GatherSortCreateBatchesFn:GatherSortCreateBatchesFnandOutputReceiverForFinishBundleto track the minimum element timestamp in the bundle (minBundleTimestamp) and assign it to batches flushed at@FinishBundleinstead ofInstant. now().SpannerIOWriteTestcoveringWriteResultsdefaultAvroCoder, minimum bundle timestamp inGatherSortCreateBatchesFn,Write#withWriteResults(),WriteGrouped#withWriteResults(), and timestamppreservation when batching is disabled.
testWriteWithResultsinSpannerWriteIT.