Skip to content

Fix ModelManager tag mismatch on release after model update (#40469) - #40473

Open
AMOOOMA wants to merge 2 commits into
apache:masterfrom
AMOOOMA:fix-40469
Open

AMOOOMA wants to merge 2 commits into
apache:masterfrom
AMOOOMA:fix-40469

Conversation

@AMOOOMA

@AMOOOMA AMOOOMA commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Fixes Issue #40469

@github-actions github-actions Bot added the python label Oct 8, 2026
@AMOOOMA

AMOOOMA commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor Author

R: @tvalentyn

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this call self.models._force_reset() ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yes it should be.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.19%. Comparing base (76f6e6d) to head (3cdcfb8).
⚠️ Report is 101 commits behind head on master.

Files with missing lines Patch % Lines
sdks/python/apache_beam/ml/inference/base.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40473      +/-   ##
============================================
+ Coverage     56.16%   56.19%   +0.02%     
  Complexity     2288     2288              
============================================
  Files          1124     1124              
  Lines        178336   178343       +7     
  Branches       1489     1489              
============================================
+ Hits         100170   100222      +52     
+ Misses        75645    75600      -45     
  Partials       2521     2521              
Flag Coverage Δ
python 79.61% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants