Repository navigation
[Python] Catch PermissionDenied when checking the feature store in VertexAIFeatureStoreEnrichmentHandler - #40463
Open
schizophrenicmaniac wants to merge 1 commit into
Conversation
…rtexAIFeatureStoreEnrichmentHandler
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40463 +/- ##
============================================
- Coverage 59.04% 59.01% -0.03%
+ Complexity 15624 15616 -8
============================================
Files 2797 2798 +1
Lines 280750 280843 +93
Branches 12488 12477 -11
============================================
- Hits 165764 165747 -17
- Misses 108540 108655 +115
+ Partials 6446 6441 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Assigning reviewers: R: @claudevdm for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VertexAIFeatureStoreEnrichmentHandler.__init__tries to check that the feature store exists and is meant to only log a warning if the caller doesn't have admin permission. But the try/except only covered creatingFeatureOnlineStoreAdminServiceClient, which makes no RPC. The call that actually checks permissions,get_feature_online_store, was in theelsebranch, so aPermissionDeniedwent uncaught and failed pipeline construction for users who only have data read access.This moves the path building and
get_feature_online_storeinto the try and catchesPermissionDeniedspecifically, soNotFoundand other errors still surface. Errors raised while creating the client are no longer turned into the "insufficient admin permission" warning either. They would fail again in__enter__anyway. Added unit tests that mock the admin client for thePermissionDeniedandNotFoundcases.Fixes #40442
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.