Skip to content

Fix Python PostCommit Flink runner log spam switching to simple logger#37720

Open
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:flink-log-level
Open

Fix Python PostCommit Flink runner log spam switching to simple logger#37720
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:flink-log-level

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 26, 2026

Logs emitted from org.apache.flink.runtime and a few Flink logger does not honor sdk_harness_log_level_override. Use simple logger and job_server_jvm_properties to set log levels instead, as done in #37313

Tested:

equivalent pytest command issed by PostCommit Python:

pytest -v apache_beam/io/gcp/bigquery_read_it_test.py::ReadTests::test_iobase_source --test-pipeline-options='--runner=FlinkRunner --project=apache-beam-testing --environment_type=LOOPBACK --temp_location=gs://temp-storage-for-end-to-end-tests/temp-it --flink_job_server_jar=<path to>beam/runners/flink/1.20/job-server/build/libs/beam-runners-flink-1.20-job-server-2.73.0-SNAPSHOT.jar --flink_conf_dir=<path to>/beam/runners/flink/src/test/resources/  --job_server_jvm_properties=-Dslf4j.provider=org.slf4j.simple.SimpleServiceProvider --job_server_jvm_properties=-Dorg.slf4j.simpleLogger.log.org.apache.flink.streaming=error --job_server_jvm_properties=-Dorg.slf4j.simpleLogger.log.org.apache.flink.runtime=error --job_server_jvm_properties=-Dorg.slf4j.simpleLogger.log.org.apache.flink.metrics=error --job_server_jvm_properties=-Dorg.slf4j.simpleLogger.log.org.apache.beam.runners.fnexecution.control=warn --job_server_jvm_properties=-Dorg.slf4j.simpleLogger.log.org.apache.beam.runners.flink.FlinkPipelineRunner=warn'

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-enables the ability to configure logging levels for the Flink job server when running Python pipelines. It resolves an issue where log level overrides were no longer honored after an SLF4J 2 migration, by generating and applying a java.util.logging.config.file dynamically. This change ensures that users can effectively manage the verbosity of Flink-related logs, improving debugging and operational insights.

Highlights

  • Logging Configuration: Implemented logic to parse sdk_harness_log_level_overrides from pipeline options and translate them into Java logging levels for Flink and Beam components.
  • Dynamic Logging Properties File: Added functionality to dynamically create a java.util.logging.config.file based on the extracted log level overrides, which is then passed as a JVM argument to the Flink job server.
  • Resource Management: Ensured that the temporary logging properties file created during job server startup is cleaned up when the job server is stopped.
  • SLF4J 2 Migration Fix: Addressed a regression likely caused by the SLF4J 2 migration, restoring the ability to override log levels for the Flink job server.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/python/apache_beam/runners/portability/flink_runner.py
    • Imported the pathlib module for path manipulation.
    • Initialized _logging_levels and _logging_file attributes in the FlinkJarJobServer constructor.
    • Overrode the start method to write a temporary logging properties file and pass its path as a JVM argument.
    • Overrode the stop method to delete the temporary logging properties file upon job server shutdown.
    • Added _extract_logging_levels method to parse sdk_harness_log_level_overrides and map Python log levels to Java java.util.logging levels.
    • Added _write_logging_properties method to create a temporary flink_job_server_logging.properties file with the specified log levels.
Activity
  • No specific activity (comments, reviews, or progress updates) was found in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn Abacn marked this pull request as draft February 26, 2026 18:06
@github-actions github-actions bot removed the runners label Feb 26, 2026
@Abacn Abacn changed the title Honor log level override for Python Flink runner job server Fix Python PostCommit Flink runner log spam switching to simple logger Feb 26, 2026
@Abacn Abacn marked this pull request as ready for review February 26, 2026 19:37
@Abacn
Copy link
Contributor Author

Abacn commented Feb 26, 2026

R: @aIbrahiim

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@aIbrahiim
Copy link
Contributor

I think this logging approach is more consistent but is this property-Dorg.slf4j.simpleLogger.log...FlinkPipelineRunner=warn is duplicated? @Abacn

@Abacn
Copy link
Contributor Author

Abacn commented Feb 26, 2026

I think this logging approach is more consistent but is this property-Dorg.slf4j.simpleLogger.log...FlinkPipelineRunner=warn is duplicated? @Abacn

Thanks for catching it. fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants