Skip to content

Conversation

@arunpandianp
Copy link
Contributor

No description provided.

@arunpandianp
Copy link
Contributor Author

@scwhittle

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @arunpandianp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a mechanism to enable State Tag Encoding V2 in Dataflow streaming jobs, controlled by a configuration flag from the Dataflow backend. This change centralizes the control over which encoding version is used, allowing for a more robust and managed rollout of this feature. The worker's execution context now dynamically determines the appropriate encoding at runtime, replacing a previous experiment-based activation.

Highlights

  • Dynamic State Tag Encoding: The Dataflow worker can now dynamically select between WindmillTagEncodingV1 and WindmillTagEncodingV2 based on a configuration flag received from the Dataflow backend.
  • Backend-Driven Configuration: The decision to use State Tag Encoding V2 is now controlled by the StreamingEngineStateTagEncodingVersion field provided by the Dataflow backend, moving away from a local experiment flag.
  • Refactored StreamingModeExecutionContext: The windmillTagEncoding field in StreamingModeExecutionContext is no longer final and its initialization has been moved to the start method, allowing for runtime configuration.
  • Global Configuration Update: A new enableStateTagEncodingV2 boolean field has been added to StreamingGlobalConfig to store the backend-provided state tag encoding version.
  • Experiment Flag Removal: The UNSTABLE_WINDMILL_TAG_ENCODING_EXPERIMENT and its associated logic have been removed, indicating a more stable and controlled rollout mechanism for V2 encoding.
  • Dependency Update: The google_api_services_dataflow client library version has been updated to v1b3-rev20260118.
  • Comprehensive Testing: New tests have been added to ensure that the WindmillTagEncoding is correctly selected based on the global configuration and that the backend flag is properly processed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@arunpandianp
Copy link
Contributor Author

R: @scwhittle

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant