Plumb custom batch parameters for autosharding from WriteFiles to FileIO.

[celeste-zeng]

• Plumbed withBatchSize(), withBatchSizeBytes(), and withBatchMaxBufferingDuration() from WriteFiles to FileIO.
• Added checks for parameters that should not be set if autosharding is enabled.
• Added a test to check the correctness of plumbing.

[gemini-code-assist]

Summary of Changes

Hello @celeste-zeng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the FileIO API in Apache Beam to provide more granular control over file writing operations, particularly for unbounded data streams with automatic sharding. It integrates batching parameters previously exclusive to WriteFiles directly into FileIO, allowing users to specify batch size, batch size in bytes, and maximum buffering duration. Crucially, it also implements robust validation to prevent incompatible sharding configurations, ensuring that auto-sharding and manual sharding parameters are not used simultaneously. These changes enhance the flexibility and correctness of FileIO for advanced use cases.

Highlights

• Batch Parameter Plumbing: Introduced withBatchSize(), withBatchSizeBytes(), and withBatchMaxBufferingDuration() methods to FileIO for configuring batching behavior, mirroring WriteFiles.
• Auto-Sharding Validation: Added validation logic to prevent conflicting sharding configurations, specifically disallowing withNumShards() or withSharding() when withAutoSharding() is enabled, and vice-versa.
• Guava Import Modernization: Updated Guava library imports from the vendored org.apache.beam.vendor.guava package to the direct com.google.common package in FileIO.java and FileIOTest.java.
• New Test Case: A new test testWriteUnboundedWithCustomBatchParameters was added to FileIOTest.java to ensure the correct functionality of custom batch parameters when writing unbounded data with auto-sharding.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[celeste-zeng]

R: @tomstepp

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers