Fix spanner io hang by closing connections

[damccorm]

Somehow spanner IO expansion is still hanging after #37305 in GoogleCloudPlatform/DataflowTemplates#3222 (fully context GoogleCloudPlatform/DataflowTemplates#3204). This tries to fix the problem differently by properly disposing of connections.

Notably, this doesn't address similar uses in

beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/DaoFactory.java

Line 119 in 1330346

final SpannerAccessor spannerAccessor = SpannerAccessor.getOrCreate(metadataSpannerConfig);

- this is ok for now since these are only used by DoFns at runtime (not expansion), so they shouldn't cause the same hangs we were observing in pipeline expansion. But they should eventually be fixed.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[damccorm]

R: @Abacn

[gemini-code-assist]

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical Spanner IO hang that occurred during pipeline expansion. The fix ensures that Spanner database connections are properly closed after use, preventing resource leaks and improving the stability of pipeline setup processes. This change specifically targets the getDialect method within SpannerIO to prevent the observed hangs.

Highlights

• Resource Management: Introduced a try-with-resources statement for SpannerAccessor in the getDialect method to ensure proper and automatic closing of Spanner connections.
• Bug Fix: Addressed a persistent Spanner IO hang issue observed during pipeline expansion by ensuring that database connections are explicitly disposed of.
• Scope Limitation: Acknowledged that similar resource management patterns in DaoFactory.java are not addressed in this pull request, as they are not implicated in the pipeline expansion hangs this PR aims to fix.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[Abacn]

Thanks!