Skip to content

Conversation

@damccorm
Copy link
Contributor

Looks like #37305 didn't work and GoogleCloudPlatform/DataflowTemplates#3222 is still failing with the current change; I think its because the spanner version is still being pulled from the gcp bom.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 15, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the google-cloud-spanner dependency was not being correctly versioned, leading to build failures in related projects. By explicitly pinning the version of the google-cloud-spanner library, this change ensures consistent and correct dependency resolution, resolving previous issues related to its version being implicitly managed by the Google Cloud Platform Bill of Materials (BOM).

Highlights

  • Dependency Version Pinning: The google-cloud-spanner dependency is now explicitly pinned to a specific version ($google_cloud_spanner_version) instead of relying on the google_cloud_platform_libraries_bom to manage its version implicitly.
  • Code Comment Update: The TODO comment related to removing pinned Spanner dependencies has been updated to include both google_cloud_spanner_bom and google_cloud_spanner, reflecting the new explicit pinning.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

damccorm added a commit to GoogleCloudPlatform/DataflowTemplates that referenced this pull request Jan 15, 2026
Updated Beam version to SNAPSHOT and changed Maven repository URL.
@damccorm
Copy link
Contributor Author

Its not clear to me why

exclude group: "com.google.cloud", module: "google-cloud-spanner"
doesn't just work here/why we're still picking up older versions of spanner...

@damccorm damccorm closed this Jan 16, 2026
@damccorm damccorm deleted the users/damccorm/pinSpannerVersions branch January 16, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant