Fix linkage check script to handle detached HEAD state #36924
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
beam-linkage-check.shscript fails to restore the original git position when starting from a detached HEAD state. This commonly happens when verifying someone else's PR, which involves merging two non-branch references.Root Cause:
The script used
git rev-parse --abbrev-ref HEADwhich returns the string "HEAD" in detached state instead of a valid reference. The cleanup function then fails to restore the original position.Fix:
git rev-parse HEADto get the full commit SHA instead of branch name-c advice.detachedHead=falseto suppress warnings during cleanup checkoutFixes #20558
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.