-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Handle null keys in gbek #36505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle null keys in gbek #36505
Conversation
|
R: @claudevdm or @Abacn (I think you both have some context). It would be good to get this in before release cut since this breaks GBEK for some scenarios |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36505 +/- ##
============================================
+ Coverage 55.08% 56.91% +1.83%
- Complexity 1666 3386 +1720
============================================
Files 1059 1221 +162
Lines 165352 186457 +21105
Branches 1190 3527 +2337
============================================
+ Hits 91080 106128 +15048
- Misses 72102 76972 +4870
- Partials 2170 3357 +1187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Handle null keys in gbek * Allow null values with hashmap * add a test * Test + remove check entirely
I noticed doing some broad validation that some transforms pass through a null key, and it triggers this condition, so this doesn't necessarily represent a decoding error like I initially thought. That should throw an exception anyways
Part of #36505
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.