Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Oct 14, 2025

I noticed doing some broad validation that some transforms pass through a null key, and it triggers this condition, so this doesn't necessarily represent a decoding error like I initially thought. That should throw an exception anyways

Part of #36505


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Oct 14, 2025
@damccorm damccorm marked this pull request as ready for review October 14, 2025 18:31
@damccorm damccorm marked this pull request as draft October 14, 2025 18:52
@damccorm
Copy link
Contributor Author

R: @claudevdm or @Abacn (I think you both have some context). It would be good to get this in before release cut since this breaks GBEK for some scenarios

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.91%. Comparing base (6dbbaa6) to head (d968b35).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #36505      +/-   ##
============================================
+ Coverage     55.08%   56.91%   +1.83%     
- Complexity     1666     3386    +1720     
============================================
  Files          1059     1221     +162     
  Lines        165352   186457   +21105     
  Branches       1190     3527    +2337     
============================================
+ Hits          91080   106128   +15048     
- Misses        72102    76972    +4870     
- Partials       2170     3357    +1187     
Flag Coverage Δ
java 70.39% <ø> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm marked this pull request as ready for review October 15, 2025 10:32
@damccorm damccorm merged commit 9ed06d0 into master Oct 15, 2025
26 of 35 checks passed
@damccorm damccorm deleted the users/damccorm/nullKeys branch October 15, 2025 10:34
stankiewicz pushed a commit to stankiewicz/beam that referenced this pull request Oct 15, 2025
* Handle null keys in gbek

* Allow null values with hashmap

* add a test

* Test + remove check entirely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants