Fix BeamSQL CalcRel DATETIME expression #35743
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed a bug in BeamSQL's handling of DATETIME expressions, ensuring that both Joda-Time's Instant and DateTime types are correctly processed when converting to milliseconds. This change improves the robustness of SQL queries involving date and time types by making the conversion more general. I've also added a new test case to validate this fix and confirm proper behavior with nested DATETIME structures.
Highlights
- Fixing DATETIME Expression Handling: The core fix addresses an issue where DATETIME expressions in BeamSQL's CalcRel were not correctly handled, specifically by changing the type conversion from DateTime.class to AbstractInstant.class. This broadens the compatibility to include both Instant and DateTime types from Joda-Time.
- Adding New Test Case for Nested DATETIME: A new test case, testNestedDatetime, was added to BeamComplexTypeTest.java to validate the fix and ensure correct handling of nested DATETIME types within SQL queries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with DATETIME expression handling in BeamSQL's CalcRel. The change correctly generalizes the type conversion to use joda.time.base.AbstractInstant, which supports both DateTime and Instant types. A new test case is added to verify the fix for nested DATETIME arrays. The changes are correct and well-implemented. I have one minor suggestion to improve the new test's maintainability by using a fixed value instead of Instant.now(). Also, please consider adding a more descriptive summary to the pull request description.
| @Test | ||
| public void testNestedDatetime() { | ||
| List<Instant> dateTimes = | ||
| ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000), Instant.now()); |
There was a problem hiding this comment.
Using Instant.now() in test data can lead to non-deterministic tests if the test logic changes in the future. It's better to use a fixed instant for reproducibility, even if this value is not directly used in the assertion.
| ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000), Instant.now()); | |
| ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000), Instant.ofEpochSecond(20000)); |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| @Test | ||
| public void testNestedDatetime() { | ||
| List<Instant> dateTimes = | ||
| ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000), Instant.now()); |
There was a problem hiding this comment.
ImmutableList cannot contain null element, right? Can we add one more test case to verify this change can support a list of Joda Instant with some null elements?
There was a problem hiding this comment.
Added nullable array field to exercise this case
vampire-hunter-lincoln
left a comment
vampire-hunter-lincoln
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
* Fix BeamSQL CalcRel DATETIME expression * Add nullable array test case * fix checkstyle (cherry picked from commit 6fe69fe)
2 participants
Fix #35736
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.