[Go] Fix reshuffle implementation to use the global window for gbk output #34462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput. Otherwise the original non-reified windowing is used and can confuse the runner, which encodes the gbk input using global windows but was attempting to decode it as original windowing. This fixes Dataflow runner harness failures when a non-global windowed pcollection is reshuffled. A work around before this fix would be to explicitly rewindow to the global window before reshuffling and reapply the desired windowing after reshuffling. This isn't caught by prism because the entire reshuffle is replaced.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34462 +/- ##
=========================================
Coverage 54.43% 54.43%
Complexity 1480 1480
=========================================
Files 1003 1003
Lines 158360 158362 +2
Branches 1079 1079
=========================================
+ Hits 86205 86209 +4
+ Misses 70056 70053 -3
- Partials 2099 2100 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Go PreCommit |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the original non-reified windowing is used and can confuse the runner, which encodes the gbk input using global windows but was attempting to decode it as original windowing.
This fixes Dataflow runner harness failures when a non-global windowed pcollection is reshuffled. A work around before this fix would be to explicitly rewindow to the global window before reshuffling and reapply the desired windowing after reshuffling.
This isn't caught by prism because the entire reshuffle is replaced.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.