Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnomalyDetection] Add a notebook for anomaly detection with Z-Score #34459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had minor feedback, overall this looks great! We should wait until 2.64.0 is released before merging, but it should be ready to go

"colab_type": "text"
},
"source": [
"<a href=\"https://colab.research.google.com/github/shunping/beam/blob/anomaly-detection-notebook-1/anomaly_detection_zscore.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove in favor of a cell below the title like

(we do this across all our notebooks)

{
"cell_type": "code",
"source": [
"! pip install apache_beam[interactive,gcp]==2.64.0rc2 --quiet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"! pip install apache_beam[interactive,gcp]==2.64.0rc2 --quiet"
"! pip install apache_beam[interactive,gcp]>=2.64.0 --quiet"

Adding this so we don't forget

"id": "0064575d-5e60-4f8b-a970-9dc39db8d331"
},
"source": [
"## Generating Synthetic Data with Concept Drifting"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"## Generating Synthetic Data with Concept Drifting"
"## Generating Synthetic Data with Concept Drift"

Nit: I think this is the right tense/may help with SEO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants