-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AnomalyDetection] Add a notebook for anomaly detection with Z-Score #34459
base: master
Are you sure you want to change the base?
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only had minor feedback, overall this looks great! We should wait until 2.64.0 is released before merging, but it should be ready to go
"colab_type": "text" | ||
}, | ||
"source": [ | ||
"<a href=\"https://colab.research.google.com/github/shunping/beam/blob/anomaly-detection-notebook-1/anomaly_detection_zscore.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove in favor of a cell below the title like
"source": [ |
{ | ||
"cell_type": "code", | ||
"source": [ | ||
"! pip install apache_beam[interactive,gcp]==2.64.0rc2 --quiet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"! pip install apache_beam[interactive,gcp]==2.64.0rc2 --quiet" | |
"! pip install apache_beam[interactive,gcp]>=2.64.0 --quiet" |
Adding this so we don't forget
"id": "0064575d-5e60-4f8b-a970-9dc39db8d331" | ||
}, | ||
"source": [ | ||
"## Generating Synthetic Data with Concept Drifting" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"## Generating Synthetic Data with Concept Drifting" | |
"## Generating Synthetic Data with Concept Drift" |
Nit: I think this is the right tense/may help with SEO
colab link:
https://colab.sandbox.google.com/github/shunping/beam/blob/anomaly-detection-notebook-1/examples/notebooks/beam-ml/anomaly_detection/anomaly_detection_zscore.ipynb