Handle rc container in _update_container_image_for_dataflow #32049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
In Python SDK submitting to Dataflow job there is a logic overriding
apache/beam_python3.X_sdk:<label>togcr.io/cloud-dataflow/v1beta3/beam_python3.X_sdk:<label>:beam/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
Line 736 in 21009e6
This generally works except the container has a release candidate tag. which were pushed to dockerhub, e.g.
apache/beam_python3.11_sdk:2.58.0rc2the correspondinggcr.io/cloud-dataflow/v1beta3/beam_python3.11_sdk:2.58.0rc2does not exist, then Dataflow job fails indefinitely.This does not happen for Python job alone, because the
__version__of the package does not contain "rcX" suffix (even though the pypi version name is rcX) and apiclient resolves to 2.XX.0. However, for JavaUsingPython xlang pipeline, this becomes a problem because the parsed in Python SDK version string is used to assemble the docker image, which contains "rc" suffix.This affected release candidate validation, e.g. in GoogleCloudPlatform/DataflowTemplates#1761
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.