Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 1, 2024

Please add a meaningful description for your change here

In Python SDK submitting to Dataflow job there is a logic overriding apache/beam_python3.X_sdk:<label> to gcr.io/cloud-dataflow/v1beta3/beam_python3.X_sdk:<label>:

return names.DATAFLOW_CONTAINER_IMAGE_REPOSITORY + '/' + image_suffix

This generally works except the container has a release candidate tag. which were pushed to dockerhub, e.g. apache/beam_python3.11_sdk:2.58.0rc2 the corresponding gcr.io/cloud-dataflow/v1beta3/beam_python3.11_sdk:2.58.0rc2 does not exist, then Dataflow job fails indefinitely.

This does not happen for Python job alone, because the __version__ of the package does not contain "rcX" suffix (even though the pypi version name is rcX) and apiclient resolves to 2.XX.0. However, for JavaUsingPython xlang pipeline, this becomes a problem because the parsed in Python SDK version string is used to assemble the docker image, which contains "rc" suffix.

This affected release candidate validation, e.g. in GoogleCloudPlatform/DataflowTemplates#1761


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Aug 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants