-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add background thread and caching of consumers to Kafka SDF #31786
base: master
Are you sure you want to change the base?
Conversation
R: @bzablocki |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
671a8a4
to
73cda8a
Compare
Thanks for testing Bartosz! I'll clean it up and add tests. I think it will be helpful for preventing the high # of consumer creations which I believe was affecting some kafka sdf users. |
73cda8a
to
6819a48
Compare
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
I'm continuing the work on this in my PR (#32597). |
Attempt to improve SDF throughput to UnboundedReader impl by similarly performing blocking kafka polls in background thread and is cached.
This allows main partition consuming thread to be blocked less, prefetches, and caching reduces consuemr connections.
Remaining work:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.