Clarify coders for side inputs on err output. #27568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27568 +/- ##
=======================================
Coverage 71.14% 71.15%
=======================================
Files 861 861
Lines 104560 104570 +10
=======================================
+ Hits 74389 74402 +13
+ Misses 28621 28619 -2
+ Partials 1550 1549 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
bullet03
pushed a commit
to akvelon/beam
that referenced
this pull request
Aug 11, 2023
* Clarify coders for side inputs on err output. * error tracking in harness. --------- Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* Clarify coders for side inputs on err output. * error tracking in harness. --------- Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny change that was necessary to understand how prism was mis-matching coders. Clarify bundle construction failures as part of ProcessBundle, and fail the instruction. Ensure data errors are treated as errors.
See #27550 and #24789.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.