returned run shortcut, fixed pipeline options validation, added logs to ToB tests #26732
Conversation
| @@ -86,6 +88,7 @@ Future<void> _checkModule(ModuleModel module, WidgetTester wt) async { | |||
| } | |||
|
|
|||
| Future<void> _checkNode(UnitModel node, WidgetTester wt) async { | |||
| print('Checking node: ${node.title}'); | |||
There was a problem hiding this comment.
Move from the test to the code, add the failing example info to the exception.
ExampleLoadingDescriptor.token
| @@ -44,6 +44,7 @@ class ShortcutsDialogContent extends StatelessWidget { | |||
| children: [ | |||
| ...[ | |||
| ...playgroundController.shortcuts, | |||
| BeamMainRunShortcut(onInvoke: () {}), | |||
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| @@ -26,6 +26,7 @@ errors: | |||
| loading: 'Error while loading.' | |||
| loadingCatalog: 'Cannot load the example catalog.' | |||
| loadingExample: 'Cannot load the example.' | |||
| failedLoadExampleWithToken: 'Failed to load the example with the token: {token}.' | |||
There was a problem hiding this comment.
There is no concept of tokens to the end-user.
| failedLoadExampleWithToken: 'Failed to load the example with the token: {token}.' | |
| failedLoadExampleWithToken: 'Failed to load the example: {token}.' |
| Example example; | ||
| try { | ||
| example = await loader.future; | ||
| } on Exception catch (_) { |
There was a problem hiding this comment.
| } on Exception catch (_) { | |
| } on Exception { |
| final example = await loader.future; | ||
| Example example; | ||
| try { | ||
| example = await loader.future; |
There was a problem hiding this comment.
| example = await loader.future; | |
| final example = await loader.future; |
and continue the rest of the successful scenario within try.
There was a problem hiding this comment.
But that if something happened in _playgroundController!.setExample? In this case exception will be incorrect
There was a problem hiding this comment.
Rename this to ExamplesLoadingException because it is only thrown when trying to load multiple examples.
/// Thrown when at least one example has failed to be loaded.| try { | ||
| example = await loader.future; | ||
| } on Exception catch (_) { | ||
| throw Exception( |
There was a problem hiding this comment.
Would be nice to have ExampleLoadingException class with token as a property. It's not the loader's job to be translation-aware.
playground/frontend/playground_components/lib/src/util/pipeline_options.dart
Outdated
Show resolved
Hide resolved
…e_options.dart Co-authored-by: alexeyinkin <leha@inkin.ru>
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
…to ToB tests (apache#26732) * returned run shortcut, fixed pipeline options validation, added logs to ToB tests * fixed failed load example error * issue26730 fix pr * fix pipeline options * tests fix * added inputFormatter to pipeline option * Update playground/frontend/playground_components/lib/src/util/pipeline_options.dart Co-authored-by: alexeyinkin <leha@inkin.ru> --------- Co-authored-by: alexeyinkin <leha@inkin.ru>
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.