[BEAM-2021][BEAM-1871] Remove DeterministicStandardCoder#2606
Closed
tgroh wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-2021][BEAM-1871] Remove DeterministicStandardCoder#2606tgroh wants to merge 1 commit intoapache:masterfrom
tgroh wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @dhalperi |
dhalperi
reviewed
Apr 20, 2017
| private abstract static class SomeRestrictionTracker | ||
| implements RestrictionTracker<SomeRestriction> {} | ||
|
|
||
| private abstract static class SomeRestrictionCoder implements Coder<SomeRestriction> {} |
Contributor
There was a problem hiding this comment.
seems unrelated to this PR.
dhalperi
requested changes
Apr 20, 2017
Contributor
dhalperi
left a comment
dhalperi
left a comment
There was a problem hiding this comment.
1 Comment, then LGTM.
Please grep for DeterministicStandardCoder in Javadoc -- I feel like it was mentioned somewhere.
tgroh
force-pushed
the
so_many_custom_coders
branch
from
a52186c to
8a0c926
Compare
Member
Author
|
I cannot find such an instance. |
|
Changes Unknown when pulling 8a0c926 on tgroh:so_many_custom_coders into ** on apache:master**. |
This isn't a particularly useful Coder. It has no defined methods other than verifyDeterministic, which has an empty implementation. Additionally, there are no guarantees that a DeterministicStandardCoder is determinsitic.
tgroh
force-pushed
the
so_many_custom_coders
branch
from
8a0c926 to
d5fc120
Compare
tgroh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This isn't a particularly useful Coder. It has no defined methods other
than verifyDeterministic, which has an empty implementation.
Additionally, there are no guarantees that a DeterministicStandardCoder
is determinsitic.