[BEAM-1988] Add join operation to the filesystem#2585
Closed
sb2nov wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-1988] Add join operation to the filesystem#2585sb2nov wants to merge 1 commit intoapache:masterfrom
sb2nov wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @chamikaramj should be ready for review |
Contributor
|
LGTM |
aaltay
reviewed
Apr 21, 2017
| @unittest.skipIf(gcsfilesystem is None, 'GCP dependencies are not installed') | ||
| class GCSFileSystemTest(unittest.TestCase): | ||
|
|
||
| def test_join(self): |
Member
There was a problem hiding this comment.
Could you add a test where the first argument ends with /
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @chamikaramj PTAL