[BEAM-1928] Add PCollections Utilities by tgroh · Pull Request #2516 · apache/beam

tgroh · 2017-04-12T19:57:39Z

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Convert a PCollection into a Proto

tgroh · 2017-04-12T19:57:48Z

R: @lukecwik

coveralls · 2017-04-12T21:04:19Z

Changes Unknown when pulling 9454dd3 on tgroh:pcollections_utilities into ** on apache:master**.

coveralls · 2017-04-12T21:23:07Z

Coverage decreased (-0.01%) to 70.576% when pulling 9454dd3 on tgroh:pcollections_utilities into 1788cef on apache:master.

asfbot · 2017-04-12T21:24:20Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9472/

Build result: FAILURE

[...truncated 1.40 MB...] at sun.security.ssl.InputRecord.readFully(InputRecord.java:465) at sun.security.ssl.InputRecord.readV3Record(InputRecord.java:593) at sun.security.ssl.InputRecord.read(InputRecord.java:532) at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:973) at sun.security.ssl.SSLSocketImpl.readDataRecord(SSLSocketImpl.java:930) at sun.security.ssl.AppInputStream.read(AppInputStream.java:105) at org.apache.maven.wagon.providers.http.httpclient.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:136) at org.apache.maven.wagon.providers.http.httpclient.impl.io.SessionInputBufferImpl.read(SessionInputBufferImpl.java:195) at org.apache.maven.wagon.providers.http.httpclient.impl.io.ContentLengthInputStream.read(ContentLengthInputStream.java:178) at org.apache.maven.wagon.providers.http.httpclient.conn.EofSensorInputStream.read(EofSensorInputStream.java:137) at org.apache.maven.wagon.AbstractWagon.transfer(AbstractWagon.java:531) at org.apache.maven.wagon.AbstractWagon.getTransfer(AbstractWagon.java:353) ... 13 more2017-04-12T21:14:19.991 [ERROR] 2017-04-12T21:14:19.991 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-04-12T21:14:19.991 [ERROR] 2017-04-12T21:14:19.991 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-04-12T21:14:19.991 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException2017-04-12T21:14:19.991 [ERROR] 2017-04-12T21:14:19.991 [ERROR] After correcting the problems, you can resume the build with the command2017-04-12T21:14:19.991 [ERROR] mvn -rf :beam-sdks-java-io-hbasechannel stoppedSetting status of 02911b4 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9472/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

coveralls · 2017-04-12T21:25:44Z

Coverage remained the same at 70.587% when pulling 9454dd3 on tgroh:pcollections_utilities into 1788cef on apache:master.

asfbot · 2017-04-12T21:35:30Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9467/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

org.apache.beam.runners.core.construction.PCollectionsTest.initializationError

--none--

asfbot · 2017-04-12T21:38:26Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9470/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

org.apache.beam.runners.core.construction.PCollectionsTest.initializationError

--none--

asfbot · 2017-04-12T21:38:28Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9471/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

org.apache.beam.runners.core.construction.PCollectionsTest.initializationError

--none--

coveralls · 2017-04-12T21:52:11Z

Coverage increased (+0.003%) to 70.59% when pulling 9454dd3 on tgroh:pcollections_utilities into 1788cef on apache:master.

asfbot · 2017-04-12T22:03:59Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9473/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

org.apache.beam.runners.core.construction.PCollectionsTest.testEncodeDecodeCycle[0: ints/Read(CreateSource).out [PCollection]]

--none--

coveralls · 2017-04-12T22:13:43Z

Coverage decreased (-0.003%) to 70.583% when pulling 9454dd3 on tgroh:pcollections_utilities into 1788cef on apache:master.

asfbot · 2017-04-12T22:17:00Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9475/

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

org.apache.beam.runners.core.construction.PCollectionsTest.testEncodeDecodeCycle[0: ints/Read(CreateSource).out [PCollection]]

--none--

tgroh · 2017-04-13T00:45:12Z

Rebased on top of #2517.

coveralls · 2017-04-13T01:39:52Z

Coverage decreased (-0.007%) to 70.082% when pulling 8565425 on tgroh:pcollections_utilities into dc672f4 on apache:master.

asfbot · 2017-04-13T01:43:53Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9485/
--none--

Convert a PCollection into a Proto

asfbot · 2017-04-13T17:08:20Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9496/

Build result: FAILURE

[...truncated 2.31 MB...] at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed. at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:302) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:764) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:711) at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:289) ... 33 more2017-04-13T16:59:40.131 [ERROR] 2017-04-13T16:59:40.131 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-04-13T16:59:40.131 [ERROR] 2017-04-13T16:59:40.131 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-04-13T16:59:40.131 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-04-13T16:59:40.132 [ERROR] 2017-04-13T16:59:40.132 [ERROR] After correcting the problems, you can resume the build with the command2017-04-13T16:59:40.132 [ERROR] mvn -rf :beam-sdks-pythonchannel stoppedSetting status of 1663e03 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9496/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

tgroh · 2017-04-13T20:05:42Z

retest this please

coveralls · 2017-04-13T21:01:00Z

Changes Unknown when pulling 1663e03 on tgroh:pcollections_utilities into ** on apache:master**.

asfbot · 2017-04-13T21:02:00Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9504/
--none--

lukecwik

Minor comments and then LGTM

lukecwik · 2017-04-14T15:18:47Z

...-construction-java/src/main/java/org/apache/beam/runners/core/construction/PCollections.java

+        return IsBounded.UNBOUNDED;
+      case UNRECOGNIZED:
+      default:
+        // Whether or not it is proto that cannot recognize it (due to the version of the


Whether or not it is proto that cannot recognize it -> Whether or this enum cannot be recognized

lukecwik · 2017-04-14T15:21:26Z

...truction-java/src/test/java/org/apache/beam/runners/core/construction/SdkComponentsTest.java


  @Test
-  public void registerPCollectionExistingNameCollision() {
+  public void registerPCollectionExistingNameCollision()  throws IOException {


nit: remove extra space between () and throws

lukecwik · 2017-04-14T16:12:30Z

LGTM

coveralls · 2017-04-14T16:54:03Z

Changes Unknown when pulling 1c13212 on tgroh:pcollections_utilities into ** on apache:master**.

asfbot · 2017-04-14T17:00:21Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9529/
--none--

tgroh force-pushed the pcollections_utilities branch 4 times, most recently from 72740a1 to 9454dd3 Compare April 12, 2017 20:43

tgroh force-pushed the pcollections_utilities branch from 9454dd3 to 8565425 Compare April 13, 2017 00:44

Add PCollections Utilities

1663e03

Convert a PCollection into a Proto

tgroh force-pushed the pcollections_utilities branch from 8565425 to 1663e03 Compare April 13, 2017 16:15

lukecwik requested changes Apr 14, 2017

View reviewed changes

fixup! Add PCollections Utilities

1c13212

asfgit closed this in eea96ff Apr 14, 2017

Conversation

tgroh commented Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgroh commented Apr 12, 2017

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

asfbot commented Apr 12, 2017

Build result: FAILURE

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

asfbot commented Apr 12, 2017

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

Uh oh!

asfbot commented Apr 12, 2017

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

Uh oh!

asfbot commented Apr 12, 2017

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

asfbot commented Apr 12, 2017

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

Uh oh!

coveralls commented Apr 12, 2017

Uh oh!

asfbot commented Apr 12, 2017

Failed Tests: 1

beam_PreCommit_Java_MavenInstall/org.apache.beam:beam-runners-core-construction-java: 1

Uh oh!

tgroh commented Apr 13, 2017

Uh oh!

coveralls commented Apr 13, 2017

Uh oh!

asfbot commented Apr 13, 2017

Uh oh!

asfbot commented Apr 13, 2017

Build result: FAILURE

Uh oh!

tgroh commented Apr 13, 2017

Uh oh!

coveralls commented Apr 13, 2017

Uh oh!

asfbot commented Apr 13, 2017

Uh oh!

lukecwik left a comment

Choose a reason for hiding this comment

Uh oh!

lukecwik Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

tgroh Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

lukecwik Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

tgroh Apr 14, 2017

Choose a reason for hiding this comment

Uh oh!

lukecwik commented Apr 14, 2017

Uh oh!

coveralls commented Apr 14, 2017

Uh oh!

asfbot commented Apr 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

tgroh commented Apr 12, 2017 •

edited

Loading