fix minor unreachable code caused by log.Fatal#22618
Merged
damccorm merged 3 commits intoapache:masterfrom Aug 14, 2022
Abirdcfly:master
Merged
fix minor unreachable code caused by log.Fatal#22618damccorm merged 3 commits intoapache:masterfrom Abirdcfly:master
damccorm merged 3 commits intoapache:masterfrom
Abirdcfly:master
Conversation
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
Contributor
Author
|
R: @lostluck |
Contributor
Author
|
R: @jrmccluskey |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #22618 +/- ##
==========================================
- Coverage 74.20% 74.20% -0.01%
==========================================
Files 708 710 +2
Lines 93462 93547 +85
==========================================
+ Hits 69355 69414 +59
- Misses 22832 22856 +24
- Partials 1275 1277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
damccorm
reviewed
Aug 11, 2022
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! Just had a couple small comments, then I'd like to merge
Co-authored-by: Danny McCormick <dannymccormick@google.com>
Co-authored-by: Danny McCormick <dannymccormick@google.com>
damccorm
approved these changes
Aug 14, 2022
Contributor
damccorm
left a comment
There was a problem hiding this comment.
LGTM - thanks for the contribution!
MarcoRob
pushed a commit
to MarcoRob/beam
that referenced
this pull request
Sep 5, 2022
* fix minor unreachable code caused by log.Fatal Signed-off-by: Abirdcfly <fp544037857@gmail.com> * Apply suggestions from code review Co-authored-by: Danny McCormick <dannymccormick@google.com> * Update sdks/python/container/boot.go Co-authored-by: Danny McCormick <dannymccormick@google.com> Signed-off-by: Abirdcfly <fp544037857@gmail.com> Co-authored-by: Danny McCormick <dannymccormick@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pkg.go.dev/log#Fatalf
see https://go.dev/play/p/iw2MCkHArJZ for example:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
R: @lostluck
R: @jrmccluskey
(just found that you have recently reviewed the go code)