sharding GCP IO tests from the javaPostCommit task #21800
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Java', | ||
| gradleTask: ':sdks:java:io:google-cloud-platform:postCommit', | ||
| gradleSwitches: [ | ||
| '-PdisableSpotlessCheck=true' | ||
| ], // spotless checked in separate pre-commit | ||
| timeoutMins: 120, | ||
| triggerPathPatterns: [ | ||
| '^sdks/java/io/google-cloud-platform/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| publishers { | ||
| archiveJunit('**/build/test-results/**/*.xml') | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,7 +196,9 @@ tasks.register("javaPreCommitPortabilityApi") { | |
| tasks.register("javaPostCommit") { | ||
| dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit") | ||
| dependsOn(":sdks:java:extensions:zetasketch:postCommit") | ||
| dependsOn(":sdks:java:io:debezium:integrationTest") | ||
|
Contributor
There was a problem hiding this comment. These line were removed in #21804 but added back in this PR. Sounds like a rebase issue. Should do a rebase instead of merge.
Contributor
There was a problem hiding this comment. Oh you're right - good catch, I thought that was part of breaking this apart, but it is not. @fernando-wizeline guessing that wasn't intentional? @Abacn want to put up a PR to remove those lines?
Contributor
Author
There was a problem hiding this comment. Oh, this is so embarrassing, sorry.
Contributor
There was a problem hiding this comment. No problem, I should've caught it too! Thanks Yi |
||
| dependsOn(":sdks:java:io:jdbc:integrationTest") | ||
| dependsOn(":sdks:java:io:kinesis:integrationTest") | ||
| dependsOn(":sdks:java:io:amazon-web-services:integrationTest") | ||
| dependsOn(":sdks:java:io:amazon-web-services2:integrationTest") | ||
| dependsOn(":sdks:java:extensions:ml:postCommit") | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this different from the other precommit builder defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they are different. I added the paths to the direct runner and gcp io folders.
Thanks Kenn!