Skip to content

[BEAM-13177][Playground] Change using of MustParse with Parse for all API methods #15990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloem merged 9 commits into from
Nov 16, 2021
Merged

[BEAM-13177][Playground] Change using of MustParse with Parse for all API methods #15990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0063075
[BEAM-13177][Playground]
Nov 12, 2021
2b6b60e
[BEAM-13177][Playground]
Nov 12, 2021
b73f5f7
[Playground][BEAM-12941][Bugfix] Fix workflows for playground applica…
snkalinin Nov 16, 2021
d449275
Revert "[Playground][BEAM-12941][Bugfix] Fix workflows for playground…
ilya-kozyrev Nov 16, 2021
69d0191
Merge branch 'apache:master' into master
ilya-kozyrev Nov 16, 2021
1bf7f6f
Merge branch 'apache:master' into master
Nov 16, 2021
72bad55
Merge branch 'apache:master' into master
ilya-kozyrev Nov 16, 2021
153c400
Merge branch 'master' into BEAM-13177-change-mustparse-with-parse
Nov 16, 2021
41eb1be
Merge branch 'master' into BEAM-13177-change-mustparse-with-parse
Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions playground/backend/cmd/server/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ func (controller *playgroundController) RunCode(ctx context.Context, info *pb.Ru

// CheckStatus is checking status for the specific pipeline by PipelineUuid
func (controller *playgroundController) CheckStatus(ctx context.Context, info *pb.CheckStatusRequest) (*pb.CheckStatusResponse, error) {
pipelineId := info.PipelineUuid
status, err := code_processing.GetProcessingStatus(ctx, controller.cacheService, uuid.MustParse(pipelineId), "CheckStatus")
pipelineId, err := uuid.Parse(info.PipelineUuid)
if err != nil {
logger.Errorf("%s: CheckStatus(): pipelineId has incorrect value and couldn't be parsed as uuid value: %s", info.PipelineUuid, err.Error())
return nil, errors.InvalidArgumentError("CheckStatus", "pipelineId has incorrect value and couldn't be parsed as uuid value: "+info.PipelineUuid)
}
status, err := code_processing.GetProcessingStatus(ctx, controller.cacheService, pipelineId, "CheckStatus")
if err != nil {
return nil, err
}
Expand All @@ -97,8 +101,12 @@ func (controller *playgroundController) CheckStatus(ctx context.Context, info *p

// GetRunOutput is returning output of execution for specific pipeline by PipelineUuid
func (controller *playgroundController) GetRunOutput(ctx context.Context, info *pb.GetRunOutputRequest) (*pb.GetRunOutputResponse, error) {
pipelineId := info.PipelineUuid
runOutput, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, uuid.MustParse(pipelineId), cache.RunOutput, "GetRunOutput")
pipelineId, err := uuid.Parse(info.PipelineUuid)
if err != nil {
logger.Errorf("%s: GetRunOutput(): pipelineId has incorrect value and couldn't be parsed as uuid value: %s", info.PipelineUuid, err.Error())
return nil, errors.InvalidArgumentError("GetRunOutput", "pipelineId has incorrect value and couldn't be parsed as uuid value: "+info.PipelineUuid)
}
runOutput, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, pipelineId, cache.RunOutput, "GetRunOutput")
if err != nil {
return nil, err
}
Expand All @@ -107,8 +115,12 @@ func (controller *playgroundController) GetRunOutput(ctx context.Context, info *

// GetRunError is returning error output of execution for specific pipeline by PipelineUuid
func (controller *playgroundController) GetRunError(ctx context.Context, info *pb.GetRunErrorRequest) (*pb.GetRunErrorResponse, error) {
pipelineId := info.PipelineUuid
runError, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, uuid.MustParse(pipelineId), cache.RunError, "GetRunError")
pipelineId, err := uuid.Parse(info.PipelineUuid)
if err != nil {
logger.Errorf("%s: GetRunError(): pipelineId has incorrect value and couldn't be parsed as uuid value: %s", info.PipelineUuid, err.Error())
return nil, errors.InvalidArgumentError("GetRunError", "pipelineId has incorrect value and couldn't be parsed as uuid value: "+info.PipelineUuid)
}
runError, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, pipelineId, cache.RunError, "GetRunError")
if err != nil {
return nil, err
}
Expand All @@ -117,8 +129,12 @@ func (controller *playgroundController) GetRunError(ctx context.Context, info *p

//GetCompileOutput is returning output of compilation for specific pipeline by PipelineUuid
func (controller *playgroundController) GetCompileOutput(ctx context.Context, info *pb.GetCompileOutputRequest) (*pb.GetCompileOutputResponse, error) {
pipelineId := info.PipelineUuid
compileOutput, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, uuid.MustParse(pipelineId), cache.CompileOutput, "GetCompileOutput")
pipelineId, err := uuid.Parse(info.PipelineUuid)
if err != nil {
logger.Errorf("%s: GetCompileOutput(): pipelineId has incorrect value and couldn't be parsed as uuid value: %s", info.PipelineUuid, err.Error())
return nil, errors.InvalidArgumentError("GetCompileOutput", "pipelineId has incorrect value and couldn't be parsed as uuid value: "+info.PipelineUuid)
}
compileOutput, err := code_processing.GetProcessingOutput(ctx, controller.cacheService, pipelineId, cache.CompileOutput, "GetCompileOutput")
if err != nil {
return nil, err
}
Expand All @@ -127,8 +143,12 @@ func (controller *playgroundController) GetCompileOutput(ctx context.Context, in

// Cancel is setting cancel flag to stop code processing
func (controller *playgroundController) Cancel(ctx context.Context, info *pb.CancelRequest) (*pb.CancelResponse, error) {
pipelineId := info.PipelineUuid
if err := utils.SetToCache(ctx, controller.cacheService, uuid.MustParse(pipelineId), cache.Canceled, true); err != nil {
pipelineId, err := uuid.Parse(info.PipelineUuid)
if err != nil {
logger.Errorf("%s: Cancel(): pipelineId has incorrect value and couldn't be parsed as uuid value: %s", info.PipelineUuid, err.Error())
return nil, errors.InvalidArgumentError("Cancel", "pipelineId has incorrect value and couldn't be parsed as uuid value: "+info.PipelineUuid)
}
if err := utils.SetToCache(ctx, controller.cacheService, pipelineId, cache.Canceled, true); err != nil {
return nil, errors.InternalError("Cancel", "error during set cancel flag to cache")
}
return &pb.CancelResponse{}, nil
Expand Down
62 changes: 62 additions & 0 deletions playground/backend/cmd/server/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,18 @@ func TestPlaygroundController_CheckStatus(t *testing.T) {
wantStatus *pb.Status
wantErr bool
}{
{
// Test case with calling CheckStatus method with incorrect pipelineId.
// As a result, want to receive an error
name: "incorrect pipelineId",
prepare: func() {},
args: args{
ctx: ctx,
request: &pb.CheckStatusRequest{PipelineUuid: "NO_UUID_STRING"},
},
wantStatus: nil,
wantErr: true,
},
{
// Test case with calling CheckStatus method with pipelineId which doesn't exist.
// As a result, want to receive an error.
Expand Down Expand Up @@ -284,6 +296,18 @@ func TestPlaygroundController_GetCompileOutput(t *testing.T) {
want *pb.GetCompileOutputResponse
wantErr bool
}{
{
// Test case with calling GetCompileOutput method with incorrect pipelineId.
// As a result, want to receive an error
name: "incorrect pipelineId",
prepare: func() {},
args: args{
ctx: ctx,
info: &pb.GetCompileOutputRequest{PipelineUuid: "NO_UUID_STRING"},
},
want: nil,
wantErr: true,
},
{
// Test case with calling GetCompileOutput method with pipelineId which doesn't exist.
// As a result, want to receive an error.
Expand Down Expand Up @@ -351,6 +375,18 @@ func TestPlaygroundController_GetRunOutput(t *testing.T) {
want *pb.GetRunOutputResponse
wantErr bool
}{
{
// Test case with calling GetRunOutput method with incorrect pipelineId.
// As a result, want to receive an error
name: "incorrect pipelineId",
prepare: func() {},
args: args{
ctx: ctx,
info: &pb.GetRunOutputRequest{PipelineUuid: "NO_UUID_STRING"},
},
want: nil,
wantErr: true,
},
{
// Test case with calling GetRunOutput method with pipelineId which doesn't exist.
// As a result, want to receive an error.
Expand Down Expand Up @@ -432,6 +468,18 @@ func TestPlaygroundController_GetRunError(t *testing.T) {
want *pb.GetRunErrorResponse
wantErr bool
}{
{
// Test case with calling GetRunError method with incorrect pipelineId.
// As a result, want to receive an error
name: "incorrect pipelineId",
prepare: func() {},
args: args{
ctx: ctx,
info: &pb.GetRunErrorRequest{PipelineUuid: "NO_UUID_STRING"},
},
want: nil,
wantErr: true,
},
{
// Test case with calling GetRunError method with pipelineId which doesn't exist.
// As a result, want to receive an error.
Expand Down Expand Up @@ -512,6 +560,20 @@ func TestPlaygroundController_Cancel(t *testing.T) {
checkFunc func() bool
wantErr bool
}{
{
// Test case with calling Cancel method with incorrect pipelineId.
// As a result, want to receive an error
name: "incorrect pipelineId",
args: args{
ctx: ctx,
info: &pb.CancelRequest{PipelineUuid: "NO_UUID_STRING"},
},
checkFunc: func() bool {
return true
},
want: nil,
wantErr: true,
},
{
// Test case with calling Cancel method.
// As a result, want to find value in cache for cache.Canceled subKey.
Expand Down