-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[BEAM-7034] Add example snippet to read fromQuery using BQ Storage API. #13083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
74 changes: 74 additions & 0 deletions
74
...ples/snippets/transforms/io/gcp/bigquery/BigQueryReadFromQueryWithBigQueryStorageAPI.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.beam.examples.snippets.transforms.io.gcp.bigquery; | ||
|
||
// [START bigquery_read_from_query_with_bigquery_storage_api] | ||
|
||
import org.apache.beam.examples.snippets.transforms.io.gcp.bigquery.BigQueryMyData.MyData; | ||
import org.apache.beam.sdk.Pipeline; | ||
import org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO; | ||
import org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO.TypedRead.Method; | ||
import org.apache.beam.sdk.transforms.MapElements; | ||
import org.apache.beam.sdk.values.PCollection; | ||
import org.apache.beam.sdk.values.TypeDescriptor; | ||
|
||
class BigQueryReadFromQueryWithBigQueryStorageAPI { | ||
public static PCollection<MyData> readFromQueryWithBigQueryStorageAPI( | ||
String project, String dataset, String table, String query, Pipeline pipeline) { | ||
|
||
// String project = "my-project-id"; | ||
// String dataset = "my_bigquery_dataset_id"; | ||
// String table = "my_bigquery_table_id"; | ||
|
||
// Pipeline pipeline = Pipeline.create(); | ||
|
||
/* | ||
String query = String.format("SELECT\n" + | ||
" string_field,\n" + | ||
" int64_field,\n" + | ||
" float64_field,\n" + | ||
" numeric_field,\n" + | ||
" bool_field,\n" + | ||
" bytes_field,\n" + | ||
" date_field,\n" + | ||
" datetime_field,\n" + | ||
" time_field,\n" + | ||
" timestamp_field,\n" + | ||
" geography_field,\n" + | ||
" array_field,\n" + | ||
" struct_field\n" + | ||
"FROM\n" + | ||
" `%s:%s.%s`", project, dataset, table) | ||
*/ | ||
|
||
PCollection<MyData> rows = | ||
pipeline | ||
.apply( | ||
"Read from BigQuery table", | ||
BigQueryIO.readTableRows() | ||
.fromQuery(query) | ||
.usingStandardSql() | ||
.withMethod(Method.DIRECT_READ)) | ||
.apply( | ||
"TableRows to MyData", | ||
MapElements.into(TypeDescriptor.of(MyData.class)).via(MyData::fromTableRow)); | ||
|
||
return rows; | ||
} | ||
} | ||
// [END bigquery_read_from_query_with_bigquery_storage_api] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid using readTableRows in an example snippet, both for the storage API and also for the existing export-based model -- this involves a needless conversion from Avro to JSON, where customers should instead be able to consume the Avro GenericRecords directly.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, agree. What would be prefered way to continue with this then?
readTableRows()
callread<T>(SerializableFunction<SchemaAndRecord, T> f)
as a part of this PRread<T>(SerializableFunction<SchemaAndRecord, T> f)
?Reading from a table
Reading with a query string
Using the BigQuery Storage API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the cycles, let's do (3). Otherwise, you can go ahead with (1) and I will take care of updating them when you're done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's merge this, and next week I can refactor all 3 examples.