Skip to content

Conversation

@dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Dec 29, 2019

Diffbased on #10479

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@dpcollins-google
Copy link
Contributor Author

dpcollins-google commented Dec 29, 2019

+R: @chamikaramj

@aaltay
Copy link
Member

aaltay commented Jan 3, 2020

R: @chamikaramj could you find a person to review this PR?

@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch from ca5d786 to 062de64 Compare January 6, 2020 20:59
@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch 4 times, most recently from 5f70308 to fd67def Compare January 9, 2020 22:31
@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch 4 times, most recently from 55145bf to a26ac21 Compare February 8, 2020 17:33
@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch 3 times, most recently from 87a4c08 to 10c8ced Compare February 11, 2020 19:57
@dpcollins-google dpcollins-google changed the title Extract IncomingMessage and OutgoingMessage from PubsubClient [BEAM-8932][Cleanup] Extract IncomingMessage and OutgoingMessage from PubsubClient Feb 20, 2020
@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch from 10c8ced to 8de9310 Compare March 5, 2020 21:01
@dpcollins-google dpcollins-google force-pushed the extract-client-messages branch from 8de9310 to 3687821 Compare March 11, 2020 20:43
@aaltay aaltay requested a review from chamikaramj March 11, 2020 21:26
@stale
Copy link

stale bot commented May 10, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label May 10, 2020
@aaltay
Copy link
Member

aaltay commented May 11, 2020

I believe this PR is still active.

@stale stale bot removed the stale label May 11, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jul 11, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants