Skip to content

[Feature Request]: Preserve JobMessage id on WaitForCompletion failure #40402

Description

@igor-dv

What would you like to happen?

When calling runnerlib.WaitForCompletion there can be a MessageResponse holding a messageId, which is only printed:

resp := msg.GetMessageResponse()
var b strings.Builder
if resp.GetTime() != "" {
    fmt.Fprintf(&b, "(time=%v)", resp.GetTime())
}
if resp.GetMessageId() != "" {
    fmt.Fprintf(&b, "(id=%v)", resp.GetMessageId())
}

The failed-job error is then built from the text only, so the caller never sees the id. I would like that messageId returned on the error (without changing the error string) so the caller can tag the failure instead of matching words.

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Prism Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions