Repository navigation
compare admin console credentials in constant time - #1307
Merged
Merged
Conversation
Member
|
@kali834x merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the admin console login in AdminActions.login checked the configured username and password with String.equals, which bails out at the first differing character and short-circuits the && between the two checks, so the time to reject a guess tracks how much of a correct prefix it carried. the login action is reachable without authentication (authorizationRequired=false), so that timing is observable to a remote caller (CWE-208). this routes both comparisons through a constant-time constantTimeEquals using MessageDigest.isEqual over the utf-8 bytes and combines them with a non-short-circuiting & so the time no longer depends on where the first mismatch falls. correct credentials still authenticate and a null configured value still fails closed.