Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-2789: Make non-reserved-word keys part of the RecordSchema & Field objects #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarmiganosca
Copy link
Contributor

@yarmiganosca yarmiganosca commented Apr 2, 2020

Currently, the Avro specification is fine with fields having keys that aren't reserved by the specification. We have use cases that need programmatic access to key-value pairs that aren't part of the specification.

Jira

Tests

  • My PR adds the following unit tests

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Currently, the Avro specification is fine with fields having keys that aren't
reserved by the specification. We have use cases that need programmatic access
to key-value pairs that aren't part of the specification.

AVRO-2789
@Fokko Fokko requested a review from tjwp April 4, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant