AVRO-4075: [csharp] Fix JsonDecoder string type failing to decode ISO string date #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,6 +45,14 @@ private class ReorderBuffer | |||
| public JsonReader OrigParser { get; set; } | |||
| } | |||
|
|
|||
| private class AvroJsonTextReader : JsonTextReader | |||
There was a problem hiding this comment.
Could make the class sealed as well; that might help inlining in the JIT compiler. Alas, it looks like private JsonReader reader; cannot be changed to private AvroJsonTextReader reader; because DoAction assigns a JsonElementReader there.
There was a problem hiding this comment.
Applied your suggestion with regards to making the class sealed. Agreed about the reader not being able to be AvroJsonTextReader, it's unfortunate its being used differently in DoAction, but the same fix has also been applied to that reader.
zcsizmadia
approved these changes
Oct 14, 2024
martin-g
approved these changes
Oct 16, 2024
|
Thank you, @NathanielAB ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixing AVRO-4075 where the JsonDecoder underlying package Newtonsoft was mixing strings with Date types when supplied with an ISO format.
Verifying this change
This change added tests and can be verified as follows:
Supplying an ISO format string for example: 1900-01-01T00:00:00Z in an Avro type string while reading with a JsonDecoder
Documentation