Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3168 Enable custom coders by default #1278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaliy
Copy link
Contributor

@kaliy kaliy commented Jul 2, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: No unit tests as this is a feature flag change

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@github-actions github-actions bot added Java Pull Requests for Java binding website labels Jul 2, 2021
Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey -- thanks so much for getting this going! I've done some tests with our internal Java code base and it looks good from our end.

I'd like to ping the dev list about this, in case anyone wants to do a test for their stuff before it appears in a release candidate -- it would be a shame to find a breakage at that point!

In any case, there's also

<org.apache.avro.specific.use_custom_coders>true</org.apache.avro.specific.use_custom_coders>
that should probably be adjusted -- I'm taking a look at some of the code in run-perf.sh and javadoc in SpecificData that might need adjusting, but this seems like something that should be finally turned on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Pull Requests for Java binding website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants