Try with libicu-dev instead of DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
apache · Oct 16, 2024 · fc7f844 · fc7f844
1 parent 754a31e
commit fc7f844
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/.github/workflows/test-lang-csharp-ARM.yml b/.github/workflows/test-lang-csharp-ARM.yml
@@ -40,7 +40,7 @@ jobs:
 
       - name: Add libzstd
         shell: bash
-        run: sudo apt-get install -y libzstd-dev
+        run: sudo apt-get install -y libzstd-dev libicu-dev
 
       - name: Install .NET SDKs
         uses: actions/setup-dotnet@v4
@@ -63,9 +63,7 @@ jobs:
         run: ./build.sh lint
 
       - name: Test
-        run: |
-          export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
-          ./build.sh test
+        run: ./build.sh test
 
   interop:
     runs-on: ubuntu-latest
@@ -74,7 +72,7 @@ jobs:
 
       - name: Add libzstd
         shell: bash
-        run: sudo apt-get install -y libzstd-dev
+        run: sudo apt-get install -y libzstd-dev libicu-dev
 
       - name: Install .NET SDKs
         uses: actions/setup-dotnet@v4
@@ -125,9 +123,7 @@ jobs:
         run: ./build.sh interop-data-generate
 
       - name: Run Interop Tests
-        run: |
-          export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
-          ./build.sh interop-data-test
+        run: ./build.sh interop-data-test
 
   arm64:
     name: C# on Linux ARM64

diff --git a/.github/workflows/test-lang-csharp.yml b/.github/workflows/test-lang-csharp.yml
@@ -40,7 +40,7 @@ jobs:
 
       - name: Add libzstd
         shell: bash
-        run: sudo apt-get install -y libzstd-dev
+        run: sudo apt-get install -y libzstd-dev libicu-dev
 
       - name: Install .NET SDKs
         uses: actions/setup-dotnet@v4
@@ -63,9 +63,7 @@ jobs:
         run: ./build.sh lint
 
       - name: Test
-        run: |
-          export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
-          ./build.sh test
+        run: ./build.sh test
 
   interop:
     runs-on: ubuntu-latest
@@ -74,7 +72,7 @@ jobs:
 
       - name: Add libzstd
         shell: bash
-        run: sudo apt-get install -y libzstd-dev
+        run: sudo apt-get install -y libzstd-dev libicu-dev
 
       - name: Install .NET SDKs
         uses: actions/setup-dotnet@v4
@@ -125,6 +123,4 @@ jobs:
         run: ./build.sh interop-data-generate
 
       - name: Run Interop Tests
-        run: |
-          export DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1
-          ./build.sh interop-data-test
+        run: ./build.sh interop-data-test