WIP: Use SyncA to generate [a]sync APIs #246
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
force-pushed
the
async-with-synca
branch
from
879ed99 to
e3c0356
Compare
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
items We need to avoid using `syn::UseRename` because it may cause issues after `synca` replacements Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Now `clear && cargo expand --no-default-features --features xyz 2>&1 > generated_xyz.rs` works for both xyz=sync and xyz=tokio in non-test code Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
… --features tokio` The `sync` feature build fails due to the new `Box::pin(...)` wrappers for all recursive calls Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This way we could use .await without extra troubles Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
TODO: examples, doc tests and IT tests Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
force-pushed
the
async-with-synca
branch
from
5ae72f9 to
ef069df
Compare
It is not finished - somehow two lines of code lead rustc to run forever Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
This way we need more cloning but otherwise Rustc complains that it cannot resolve whether &schema::tokio::Schema is Send Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed with whitespaces ignored - https://github.com/apache/avro-rs/pull/246/files?w=1