[BLAZE-747][FOLLOW-UP] Fix user changed in FFI NextBatch#769
Merged
richox merged 1 commit intoapache:masterfrom Jan 16, 2025
Merged
[BLAZE-747][FOLLOW-UP] Fix user changed in FFI NextBatch#769richox merged 1 commit intoapache:masterfrom
richox merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@richox Would you mind reviewing this pr? |
richox
approved these changes
Jan 16, 2025
Member
|
LGTM，thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
follow-up #748
Closes #747
Rationale for this change
When executing
ConvertToNativeExec, from native to JVM (callingexportNextBatchin Rust), the user has already exited the context initially set byrunAsSparkUserinCoarseGrainedExecutorBackend.run. Therefore, it is necessary to re-enter thePrivilegedExceptionActionto executeexportNextBatch.What changes are included in this PR?
We found the error occur in
ArrowFFIExporterat line 64, so the change wraps this code inPrivilegedExceptionActionas well. Alternatively, instead of checking if the user has changed, always execute inPrivilegedExceptionAction. This makes the code simpler and maintains consistency with therunAsSparkUser.https://github.com/kwai/blaze/blob/ba86c7ae438f90ab8ec1fe0752067e1c8d7f5d67/spark-extension/src/main/scala/org/apache/spark/sql/execution/blaze/arrowio/ArrowFFIExporter.scala#L64
Are there any user-facing changes?
No