Conversation
added 12 commits
December 10, 2024 14:19
richox
reviewed
Dec 12, 2024
| .setPartitionCount(numPartitions) | ||
| .addAllHashExpr(nativeHashExprs.asJava) | ||
| case RoundRobinPartitioning(_) => | ||
| PhysicalHashRepartition |
Contributor
There was a problem hiding this comment.
i suggest using a new separated PhysicalRoundRobinRepartition other than reusing hash repartition here.
| fn sort_batch_by_partition_id( | ||
| batch: RecordBatch, | ||
| partitioning: &Partitioning, | ||
| sum_num_rows: usize, |
Contributor
There was a problem hiding this comment.
maybe current_num_rows is a better name
| let (parts, sorted_batch) = self | ||
| .sort_time | ||
| .with_timer(|| sort_batch_by_partition_id(batch, partitioning))?; | ||
| .with_timer(|| sort_batch_by_partition_id(batch, partitioning, self.num_rows))?; |
Contributor
There was a problem hiding this comment.
we can sort before updating self.num_rows so that we don't need to substract batch.num_rows() in the implementation.
added 8 commits
December 13, 2024 10:19
lihao712
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Add native RoundRobin repartition support.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?