Add spotless check and apply in reformat#1083
Merged
richox merged 1 commit intoapache:masterfrom Aug 2, 2025
Merged
Conversation
cxzl25
commented
Jul 31, 2025
| SHIM=$ver | ||
| if [[ "$CHECK" == "true" ]]; then | ||
| mvn compile test-compile scalafix:scalafix -Dscalafix.mode=CHECK -Dscalafix.skipTest=true -P"${SHIM}" -P"${MODE}" | ||
| mvn spotless:check compile test-compile scalafix:scalafix -Dscalafix.mode=CHECK -Dscalafix.skipTest=true -P"${SHIM}" -P"${MODE}" |
Contributor
Author
There was a problem hiding this comment.
The format of pom.xml and scala files is not checked correctly before spotless:check.
wForget
approved these changes
Jul 31, 2025
richox
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Now CI style is missing some spotless plugin check
What changes are included in this PR?
Are there any user-facing changes?